Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update displayed user status when updating user status - 11509 #2088

Open
wants to merge 3 commits into
base: release/cycle-3.112
Choose a base branch
from
Open

fix: update displayed user status when updating user status - 11509 #2088

wants to merge 3 commits into from

Conversation

El-Fitz
Copy link
Contributor

@El-Fitz El-Fitz commented Oct 23, 2024

Issue

When updating the user's availability, the user's new availability status was not immediately updated in the account view.
It was fixed in #1922, so we backported the fix.

This is tagged do not merge for now as no delivery is scheduled.

Testing

  • Log in
  • Go to user account
  • Change the status
  • Status is updated in the profile screen

Checklist

  • Title contains a reference JIRA issue number like [WPB-XXX].
  • Description is filled and free of optional paragraphs.
  • Adds/updates automated tests.

UI accessibility checklist

If your PR includes UI changes, please utilize this checklist:

  • Make sure you use the API for UI elements that support large fonts.
  • All colors are taken from WireDesign.ColorTheme or constructed using WireDesign.BaseColorPalette.
  • New UI elements have Accessibility strings for VoiceOver.

@El-Fitz El-Fitz requested review from agisilaos and caldrian October 23, 2024 13:54
@El-Fitz El-Fitz self-assigned this Oct 23, 2024
@echoes-hq echoes-hq bot added the echoes: unplanned Any work item that isn’t part of the product or technical roadmap. label Oct 23, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 23, 2024 •
edited
Loading

Test Results

1 861 tests   1 852 ✅  2m 6s ⏱️
  304 suites      0 💤
    1 files        9 ❌

For more details on these failures, see this check.

Results for commit c42cf4c.

♻️ This comment has been updated with latest results.

@datadog-wireapp
Copy link

datadog-wireapp bot commented Oct 23, 2024 •
edited
Loading

Datadog Report

Branch report: fix/update-user-status-on-change-#WPB-11509
Commit report: 2bdcc4b
Test service: wire-ios-mono

❌ 9 Failed (0 Known Flaky), 1852 Passed, 0 Skipped, 5.4s Total Time

❌ Failed Tests (9)

This report shows up to 5 failed tests.

  • testThatItDisplaysAudioMessage_55 - Wire_iOS_Tests.ConversationReplyCellTests - Details

    Expand for error 
     XCTAssertTrue failed
 
 wire-ios/Wire-iOS Tests/ConversationReplyCellTests.swift:493

  • testThatItDisplaysErrorForDeletedMessage_57 - Wire_iOS_Tests.ConversationReplyCellTests - Details

    Expand for error 
     XCTAssertTrue failed
 
 wire-ios/Wire-iOS Tests/ConversationReplyCellTests.swift:493

  • testThatItDisplaysErrorForUnsupportedMessageType_57 - Wire_iOS_Tests.ConversationReplyCellTests - Details

    Expand for error 
     XCTAssertTrue failed
 
 wire-ios/Wire-iOS Tests/ConversationReplyCellTests.swift:493

  • testThatItDisplaysFileMessage_54 - Wire_iOS_Tests.ConversationReplyCellTests - Details

    Expand for error 
     XCTAssertTrue failed
 
 wire-ios/Wire-iOS Tests/ConversationReplyCellTests.swift:493

  • testThatItDisplaysLinkPreviewAsText_51 - Wire_iOS_Tests.ConversationReplyCellTests - Details

    Expand for error 
     XCTAssertTrue failed
 
 wire-ios/Wire-iOS Tests/ConversationReplyCellTests.swift:493

@netbe netbe enabled auto-merge (squash) November 29, 2024 14:05
@netbe netbe removed the DO NOT MERGE label Dec 3, 2024
@netbe netbe removed the request for review from agisilaos January 8, 2025 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caldrian caldrian caldrian approved these changes

@netbe netbe netbe approved these changes

Assignees

@El-Fitz El-Fitz

Labels
echoes: unplanned Any work item that isn’t part of the product or technical roadmap.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@El-Fitz @netbe @caldrian